Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression of GLES2 materials in RC1 3.1. #26860

Closed
OlexiyKravchuk opened this Issue Mar 9, 2019 · 7 comments

Comments

Projects
None yet
5 participants
@OlexiyKravchuk
Copy link

OlexiyKravchuk commented Mar 9, 2019

Godot version:
In version of Godot_v3.1-rc1_win64.exe, compared to Godot_v3.1-beta11_win64.exe

OS/device including version:
Windows 7 Radeon HD 3650

Issue description:
GLES2 materials in RС1 3.1, textures lose clarity, strange stripes are visible.

image

Minimal reproduction project:
https://www.dropbox.com/s/yb0j0yyfasw459v/3D%20mat.zip?dl=0

@OlexiyKravchuk OlexiyKravchuk changed the title Regression of GLES2 materials in RK 1 3.1. Regression of GLES2 materials in RC1 3.1. Mar 9, 2019

@hpvb hpvb added the bug label Mar 10, 2019

@hpvb hpvb added this to the 3.1 milestone Mar 10, 2019

@clayjohn

This comment has been minimized.

Copy link
Contributor

clayjohn commented Mar 10, 2019

I can't reproduce on linux, Ubuntu 16.04, intel HD graphics

@akien-mga

This comment has been minimized.

Copy link
Member

akien-mga commented Mar 10, 2019

It seems to be due to showing the 3D gizmos, did you try in beta 11 with gizmos disabled maybe?

@akien-mga

This comment has been minimized.

Copy link
Member

akien-mga commented Mar 10, 2019

I can reproduce the blurry reflection with the provided project on Linux (Mageia 7) with Nvidia GTX 670MX.

3.1 beta 11:
Screenshot_20190310_133402

3.1 RC1 and 59aa79f:
Screenshot_20190310_133446

I don't have the issue with the gizmos leaking though.

@akien-mga

This comment has been minimized.

Copy link
Member

akien-mga commented Mar 10, 2019

The blurry reflection is a regression from 7141c73, a local revert fixes it.

I thought 7141c73#diff-153d52221f41b71accc0f5b91c491702R1179 looked dubious so I removed the / 4 locally, but that completely breaks it (everything becomes black).

@akien-mga

This comment has been minimized.

Copy link
Member

akien-mga commented Mar 11, 2019

The blurry reflection should be fixed by #26898.

If you can still reproduce the issue with the gizmos appearing on meshes, that would be worth reporting in a new issue.

@OlexiyKravchuk

This comment has been minimized.

Copy link
Author

OlexiyKravchuk commented Mar 13, 2019

This is still broken, and deep regression, I tried to run on another computer, here is the result of photos, versions - (Godot_v3.1-beta11_win64.exe, Godot_v3.1-rc1_win64.exe, Godot_v3.1-rc2_win64.exe, Godot_v3. 1-rc3_win64.exe) at the last, additional errors are visible ...
image
image
image
image

@clayjohn

This comment has been minimized.

Copy link
Contributor

clayjohn commented Mar 13, 2019

The error is unrelated. It must have been introduced somewhere else.

The results in Beta11 are slightly crisper because they used a slightly larger radiance map then they should have. To reproduce that level of detail, you should use a larger radiance map. You can set it under environment>sky.

The reason that the radiance is not the same is that it has been updated to match the results of the GLES3 backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.