Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BMP image loader fails to import images with 8, 4 and 1 bit depths #28020

Closed
Xrayez opened this issue Apr 14, 2019 · 3 comments · Fixed by #28267
Closed

BMP image loader fails to import images with 8, 4 and 1 bit depths #28020

Xrayez opened this issue Apr 14, 2019 · 3 comments · Fixed by #28267

Comments

@Xrayez
Copy link
Contributor

Xrayez commented Apr 14, 2019

Godot version:
3.2

OS/device including version:
Windows 10

Issue description:
Try to load .bmp images with 8, 4 and 1 bit depth, it will fail to import them.
Loading 24 bit images works alright since #20038.

I know the bmp hate but here it is 🐛.

Minimal reproduction project:
bmp-8bit-import.zip

@akien-mga
Copy link
Member

CC @SaracenOne

@Xrayez
Copy link
Contributor Author

Xrayez commented Apr 15, 2019

@SaracenOne note that I'm currently working on palette support in images that could help to solve this. I've made some progress already on this, but you could fix it independently of whether the feature is merged or not (#28013).

@Xrayez
Copy link
Contributor Author

Xrayez commented Apr 16, 2019

For reference, the issue with importing 8-bit bmp images was fixed as part of my PR using the new palette API 45917ac, I suppose it would be relatively easy to do the same with 4-bit and 1-bit images done.

@akien-mga akien-mga added this to the 3.2 milestone Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants