Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ItemList new 3.2 behavior on touchscreen is weird (Android) #33428

Closed
Coldragon opened this issue Nov 7, 2019 · 5 comments · Fixed by #33536

Comments

@Coldragon
Copy link

@Coldragon Coldragon commented Nov 7, 2019

Godot version: 3.2.beta1

OS/device including version: Android 10, Android 6.0.1, Android 8.1

Issue description: Before 3.2 ( =< 3.1.1) ItemList didn't have a reaction to touchscreen beside touching the scrollbar, now it behave strangely and go straight up or straight down (not smoothly). It conflict with the script I used that was smooth : #13235 (comment) even if I disable the script.

Steps to reproduce: Create an ItemList with more element than it can be showed (to be scrollable)

Videos:
https://streamable.com/77eeh Godot 3.2.beta1.official on OnePlus 7T Android 10 GLES3 (Without custom script)
https://streamable.com/wdcru Godot 3.1.1.stable.official on OnePlus 7T Android 10 GLES (Without custom script)
https://streamable.com/t8dvd Godot 3.1.1.stable.official on OnePlus 7T Android 10 GLES (With custom script)

@akien-mga akien-mga added this to the 3.2 milestone Nov 7, 2019
@akien-mga

This comment has been minimized.

Copy link
Member

@akien-mga akien-mga commented Nov 7, 2019

I can reproduce the issue on my Android phone with 3.2 beta 1. No problem on the other hand on my Linux laptop with a touchscreen.

@akien-mga

This comment has been minimized.

Copy link
Member

@akien-mga akien-mga commented Nov 7, 2019

The issue on Android is probably caused by #25474, CC @jeremyz.

OS/device including version: iOS 12.x, Android 10, Android 6.x, Android 8.1

Do you actually reproduce the issue on iOS? Because InputEventPanGesture should only be implemented on macOS and Android right now.

@akien-mga

This comment has been minimized.

Copy link
Member

@akien-mga akien-mga commented Nov 7, 2019

Reproduction project (with display of event type): ItemListScroll.zip

@Coldragon

This comment has been minimized.

Copy link
Author

@Coldragon Coldragon commented Nov 7, 2019

No, it's a mistake for iOS, my bad, ItemList doesn't behave on scroll outside of the scrollbar. I was restarting my Mac while you posted your comment (I'll edit my issue)

@akien-mga akien-mga changed the title ItemList new 3.2 behavior on touchscreen is weird ItemList new 3.2 behavior on touchscreen is weird (Android) Nov 7, 2019
@jeremyz

This comment has been minimized.

Copy link
Contributor

@jeremyz jeremyz commented Nov 8, 2019

@akien-mga I think I have a fix for the android issue, see my last comment on #25474,
I'll try to test it in the next 48 hours.

akien-mga added a commit to akien-mga/godot that referenced this issue Nov 11, 2019
…nGesture"

This reverts commit 9cc6649.

This caused regressions with the handling of screen drag events.

Fixes godotengine#33428.
Fixes godotengine#33459.
Fixes godotengine#33470.
Phischermen added a commit to Phischermen/godot that referenced this issue Nov 17, 2019
…nGesture"

This reverts commit 9cc6649.

This caused regressions with the handling of screen drag events.

Fixes godotengine#33428.
Fixes godotengine#33459.
Fixes godotengine#33470.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.