Animations not looping on inherited scenes from a 3D gltf animated mesh

[NathanLovato]

---

Bugsquad note: This issue has been confirmed several times already. No need to confirm it further.

---

Godot version:

Commit 3aa46a5
Latest master from december 16, 2019

OS/device including version:

Linux Pop_OS! 19.10

Issue description:

In inherited scenes from animated 3D meshes, animations won't loop at runtime even though I set the animations to loop on the animation player. The animation does loop in the editor, the problem is only in-game.

Steps to reproduce:

1. Import a .glb or .fbx rigged and animated mesh in Godot
2. Create a new inherited scene from the imported mesh
3. Select the animation player and set an animation to autoplay and loop
4. Create a scene to see the character in the game
5. Play the game

The animation doesn't loop. The looping setting is properly saved in the inherited scene: if you set the animated mesh scene to "Editable children" in the game scene, you'll see the looping option is still checked on the AnimationPlayer.

Note that if you clear the inheritance on the animated character, looping will then work as expected.

Minimal reproduction project:

Here is a working project with the issue above. The character is only in gltf2 but the issue is the same with fbx. I didn't include the fbx as the character's mesh normals won't import well at the moment.

animation-looping-bug.zip

[fire]

This bug is not related to #32678.

The animation needs to be saved as a separate .anim file so that the loop setting is saved.

[fire]

@NathanLovato Is using the cycle / loop hint flags enough for your use case?

[NathanLovato]

That is, naming the animations in Blender so that they loop properly in Godot? Sure, that would be fine by me.

[fire]

Please close the issue after testing with your model and animations.

[NathanLovato]

This bug report is about the loop animation checkbox not working in the Godot editor. While I'm fine using a workaround personally, shouldn't this button be at least disabled with inherited scenes from imported models? At the moment, you can still toggle it but it won't do anything.

[fire]

I wonder if we have a locked state for that button. We have on and off.

[unfa]

Doesn't this only break when using AnimationTree to drive the imported GLTF 2.0 scene's AnimationPlayer?

I have only had problems with animations not looping once I started using the AnimationTree.
Before when I used the AnimationPlayer directly it was fine.

I was able to workaround this by adding a a piece of code that'll set the loop flags for specific animations on ready:

func _ready():
	
	var anim_player = $Mesh/AnimationPlayer
	var animations = ['Run', 'Idle', 'Idle2', 'Fly']
	
	for animation in animations:
		animation = anim_player.get_animation(animation)	
		animation.loop = true

[NathanLovato]

No, this happens with the raw inherited scene from the gltf file. See the steps and test project above.

[fire]

I can reproduce the issue.

[fire]

I can check if the animation resource is_local_to_scene(), but I have to go through everything. So I don't think it's the solution.