Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed uninitialized local and improved msbuild search and usability #11845

Merged
merged 3 commits into from
Oct 5, 2017
Merged

Fixed uninitialized local and improved msbuild search and usability #11845

merged 3 commits into from
Oct 5, 2017

Conversation

neikeq
Copy link
Contributor

@neikeq neikeq commented Oct 4, 2017

  • Fixed uninitialized local.
  • When attaching a script to an object, we add it to the C# project if it's not already in (Noticed a few issues on domain unload after this, running the GC before finalizing the domain fixed them).
  • Search msbuild in a few other locations other than PATH on Unix. Notably: /Library/Frameworks/Mono.framework/Versions/Current/bin/ on OSX.

@neikeq neikeq added this to the 3.0 milestone Oct 4, 2017
@neikeq neikeq mentioned this pull request Oct 4, 2017
Closed
@neikeq neikeq merged commit 928efe0 into godotengine:master Oct 5, 2017
@neikeq neikeq mentioned this pull request Oct 5, 2017
Closed
@neikeq neikeq deleted the music-is-overrated branch May 14, 2021 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug enhancement topic:dotnet
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
1 participant
@neikeq