New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes wrong vertical font layout in RichTextLabel #15711

Merged
merged 1 commit into from Feb 14, 2018

Conversation

Projects
None yet
3 participants
@poke1024
Contributor

poke1024 commented Jan 14, 2018

In rc1, RichTextLabel computes the wrong vertical text offsets for lines with multiple fonts, as it lacks a proper layout step that determines the common baseline for a whole line that all fonts will be rendered on.

This fixes it. Not yet extensively tested.

Before:

before

After:

fixed

@akien-mga akien-mga added this to the 3.0 milestone Jan 14, 2018

@poke1024

This comment has been minimized.

Contributor

poke1024 commented Jan 14, 2018

Also happened with different font sizes; before:

master

Fixed:

fixed

@akien-mga akien-mga modified the milestones: 3.0, 3.1 Jan 15, 2018

@hpvb hpvb added the cherrypick label Jan 29, 2018

@akien-mga akien-mga merged commit f1ee573 into godotengine:master Feb 14, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hpvb hpvb removed the cherrypick label Feb 21, 2018

@hpvb

This comment has been minimized.

Member

hpvb commented Mar 1, 2018

This PR caused a regression. See #17139

@hpvb

This comment has been minimized.

Member

hpvb commented Mar 1, 2018

Potential fix: #17144

@hpvb

This comment has been minimized.

Member

hpvb commented Mar 1, 2018

Another potential fix: #17145 <-- this one looks better I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment