New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #15895, audio streams don't signalling finished after the first one #15910

Merged
merged 1 commit into from Feb 1, 2018

Conversation

Projects
None yet
3 participants
@robfram
Contributor

robfram commented Jan 20, 2018

Fix issue #15895, audio streams don't signalling finished after the first one
if the audio player is set to play again, due to the order of calls in
_notification. First it emits the signal, and later it disable the internal
processing regardless what the callback did.

Changed to emit the signal at the end to ensure the changes done at callback
remains.

Fix issue 15895, audio streams don't signalling finished after the fi…
…rst one

if the audio player is set to play again due to the order of calls in
_notification. First it emits the signal, and later it disable the internal
processing regardless what the callback did.

Changed to emit the signal at the end to ensure the changes done at callback
remains.

@akien-mga akien-mga added this to the 3.1 milestone Jan 20, 2018

@hpvb hpvb added the cherrypick label Jan 29, 2018

@akien-mga akien-mga merged commit 4cb64fe into godotengine:master Feb 1, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@robfram robfram deleted the robfram:fix-audio-signal-issue-15895 branch Feb 1, 2018

@hpvb hpvb removed the cherrypick label Feb 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment