New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color:fix setting V switch S to old V value #16916

Merged
merged 1 commit into from Feb 22, 2018

Conversation

Projects
None yet
3 participants
@ghost

ghost commented Feb 22, 2018

The bug:

var c = Color(0.1,0.2,0.3)
print(c.h,c.s,c.v)
c.v=0.6
print(c.h,c.s,c.v) # s is  wrongly set to 0.3

@ghost ghost added bug topic:core labels Feb 22, 2018

@ghost ghost added this to the 3.1 milestone Feb 22, 2018

@akien-mga

This comment has been minimized.

Member

akien-mga commented Feb 22, 2018

Hehe, I was looking at this literally 15 min ago but missed it :)

@akien-mga akien-mga merged commit bd01fb5 into godotengine:master Feb 22, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ghost ghost deleted the color branch Feb 22, 2018

@hpvb hpvb removed the cherrypick label Feb 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment