Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mono: Project building fixes #18949

Merged
merged 1 commit into from May 17, 2018

Conversation

@neikeq
Copy link
Member

commented May 16, 2018

  • Set (Csc/Vbc/Fsc)ToolExe environment variables to point to the batch files in Mono's bin directory when building with Mono's MSBuild. Thanks to @PJB3005 for finding this out, here I was trying to point it to the exe...
  • Set Mono's MSBuild as the default build tool on Windows.
  • Generate projects with portable DebugType instead of full.
Mono: Project building fixes
- Set (Csc/Vbc/Fsc)ToolExe environment variables to point to the batch files in Mono's bin directory when building with Mono's MSBuild.
- Set Mono's MSBuild as the default build tool on Windows.
- Generate projects with portable DebugType instead of full.

@neikeq neikeq added this to the 3.1 milestone May 16, 2018

@akien-mga akien-mga merged commit c3510cd into godotengine:master May 17, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Valentactive added a commit to Valentactive/godot that referenced this pull request May 17, 2018

fixes build error on Linux after its introduction in godotengine#18949
The function expects now a return value. Returning NULL seems to work in
this case.

akien-mga added a commit that referenced this pull request May 17, 2018

Merge pull request #18967 from Valentactive/fix-mono-build-linux
fixes build error on Linux after its introduction in #18949
@akien-mga

This comment has been minimized.

Copy link
Member

commented May 17, 2018

#18967 should be cherry-picked with/within this one.

@Chaosus

This comment has been minimized.

Copy link
Member

commented May 17, 2018

Your mono runtime and class libraries are out of sync.
The out of sync library is: D:\GIT\godot\bin/GodotSharpTools.dll

Unhandled Exception:
System.MissingMethodException: Attempted to access a missing method.
  at (wrapper managed-to-native) GodotSharpTools.Build.BuildInstance.godot_icall_BuildInstance_get_MSBuildInfo(string&,string&)

@neikeq what to do ?(windows 10)

@hpvb

This comment has been minimized.

Copy link
Member

commented Jun 1, 2018

Cherry picked into 3.0.3

hpvb added a commit that referenced this pull request Jun 1, 2018

fixes build error on Linux after its introduction in #18949
The function expects now a return value. Returning NULL seems to work in
this case.

(cherry picked from commit 6c74f3d)

malcolmhoward added a commit to malcolmhoward/godot that referenced this pull request Jul 31, 2018

fixes build error on Linux after its introduction in godotengine#18949
The function expects now a return value. Returning NULL seems to work in
this case.

malcolmhoward added a commit to malcolmhoward/godot that referenced this pull request Jul 31, 2018

fixes build error on Linux after its introduction in godotengine#18949
The function expects now a return value. Returning NULL seems to work in
this case.

(cherry picked from commit 6c74f3d)

malcolmhoward added a commit to malcolmhoward/godot that referenced this pull request Jul 31, 2018

fixes build error on Linux after its introduction in godotengine#18949
The function expects now a return value. Returning NULL seems to work in
this case.

malcolmhoward added a commit to malcolmhoward/godot that referenced this pull request Jul 31, 2018

fixes build error on Linux after its introduction in godotengine#18949
The function expects now a return value. Returning NULL seems to work in
this case.

(cherry picked from commit 6c74f3d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.