Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not record year of build #21554

Merged
merged 1 commit into from Aug 29, 2018
Merged

Do not record year of build #21554

merged 1 commit into from Aug 29, 2018

Conversation

bmwiedemann
Copy link
Contributor

This value becomes part of get_version_info output,
but if it is changing every year without any other change,
it cannot be a useful indicator of anything.

Using a constant value, makes the package build reproducible.
See https://reproducible-builds.org/ for why this is good.

https://stackoverflow.com/questions/2390230/do-copyright-dates-need-to-be-updated also suggests, that copyright years do not have to be updated because expiry is counted from death of author, not from date of creation.

This value becomes part of get_version_info output,
but if it is changing every year without any other change,
it cannot be a useful indicator of anything.

Using a constant value, makes the package build reproducible.
See https://reproducible-builds.org/ for why this is good.
@akien-mga
Copy link
Member

Fine with me, we'll just have to remember about it when bumping copyright year in headers.

https://stackoverflow.com/questions/2390230/do-copyright-dates-need-to-be-updated also suggests, that copyright years do not have to be updated because expiry is counted from death of author, not from date of creation.

That would be true if Godot had been made in 2007 and then never updated. Then Juan and Ariel could claim copyright from 2007 on their work, and that's it.
But Godot is getting substantially revised all the time, and I think it's fair both to original authors and to new contributors to make the copyright year encompass all of Godot's lifetime, so 2007-now.

@akien-mga akien-mga merged commit d2abbfb into godotengine:master Aug 29, 2018
@akien-mga
Copy link
Member

@hpvb Marking for cherry-picking as I guess openSUSE will want this patch to package 3.0.7+.

@akien-mga
Copy link
Member

Now that Godot 3.1 has been released, we don't plan to cherry-pick new features and enhancements to the 3.0 branch, unless there is very strong support in favor of it. Removing cherrypick label for 3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants