Deprecate slave keyword in favor of puppet. #22087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Sep 14, 2018
|
Thanks, changes look good. If you want to squash commits eventually, I'd suggest to keep the 4th one separate as it's not directly related to the |
The slave keyword will still be available as deprecated in 3.1 but will be dropped from future releases.
NOTE: This changes the RPC_MODE_* enum values. Games should be re-exported. GDNative rebuilt.
|
Squashed |
vnen
reviewed
Sep 14, 2018
vnen
approved these changes
Sep 14, 2018
akien-mga
reviewed
Sep 14, 2018
LikeLakers2
reviewed
Sep 14, 2018
|
Good to merge once CI passes. |
reduz
approved these changes
Sep 15, 2018
This comment has been minimized.
This comment has been minimized.
|
@Faless In case you want to check my docs changes: godotengine/godot-docs@acfd853 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
After much discussion, the name change is here.
slavekeyword is being renamed topuppetslavesynckeyword is being renamed topuppetsyncThe
slavekeyword will still exists in3.1as deprecated, and will be dropped in future release.Additionally the
synckeyword is now more clearly deprecated in favor ofremotesync.This changed the enum values of the keywords (so re-export script and re-build GDNative after this commit).
Closes #7986 .
I still haven't managed to build/install msbuild, so if someone could help testing the Mono build I would appreciate it.
EDIT: Once agreed upon, I'll squash the commits.