Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show play position of sub state machine #24796

Merged
merged 1 commit into from Apr 23, 2019

Conversation

@guilhermefelipecgs
Copy link
Member

guilhermefelipecgs commented Jan 5, 2019

Sub state machine now show the play position of the current state playing. (this makes much more sense imo because now we have feedback of what's happening)

before:
peek 05-01-2019 20-09
after:
peek 05-01-2019 20-14

This is the sub state machine used in these example:
captura de tela de 2019-01-05 20-14-27

@akien-mga akien-mga added this to the 3.1 milestone Jan 6, 2019
@guilhermefelipecgs guilhermefelipecgs force-pushed the guilhermefelipecgs:fix_play_pos_sm branch from bc0f185 to b23f48b Jan 7, 2019
@akien-mga akien-mga modified the milestones: 3.1, 3.2 Jan 7, 2019
Copy link
Contributor

schweigert left a comment

\o/

@guilhermefelipecgs guilhermefelipecgs force-pushed the guilhermefelipecgs:fix_play_pos_sm branch 2 times, most recently from ec47f98 to 8fe2181 Jan 12, 2019
Sub state machine now show the play position of the current state
playing.
@guilhermefelipecgs guilhermefelipecgs force-pushed the guilhermefelipecgs:fix_play_pos_sm branch from 8fe2181 to 771fbd2 Jan 13, 2019
@hpvb hpvb added the cherrypick:3.1 label Apr 23, 2019
@hpvb hpvb merged commit 2ea7576 into godotengine:master Apr 23, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hpvb

This comment has been minimized.

Copy link
Member

hpvb commented Apr 23, 2019

Thanks!

@guilhermefelipecgs guilhermefelipecgs deleted the guilhermefelipecgs:fix_play_pos_sm branch Apr 23, 2019
@akien-mga

This comment has been minimized.

Copy link
Member

akien-mga commented Apr 25, 2019

Note to release maintainers: if this one is cherry-picked, its fixup #28336 should be included too.

@akien-mga

This comment has been minimized.

Copy link
Member

akien-mga commented Aug 21, 2019

Cherry-picked for 3.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.