Add mono log profiler support #26513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably a nice improvement for 3.1 |
|
Looks good. Indeed, it would be great if we integrated this with the editor, but for now this will do. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds mono log profiler support. When the global project setting is enabled, the mono log profiler is enabled and the output is written to output.mlpd.
These can be analyzed using the mono
mprof-reporttool:mprof-report output.mlpdThis was the fastest path to success, but I think a better long term solution would be to create a custom mono profiler implementation to replace the default log profiler. This could register with the mono profiler callbacks and feed information to the existing Godot profiling UI.