Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print errors comming from callv #26629

Merged
merged 1 commit into from Mar 5, 2019

Conversation

Projects
None yet
2 participants
@bojidar-bg
Copy link
Member

bojidar-bg commented Mar 5, 2019

Fixes #18386.

Additionally, changed a bit how space for the arguments is allocated, making it similar to MessageQueue::_call_function:

void MessageQueue::_call_function(Object *p_target, const StringName &p_func, const Variant *p_args, int p_argcount, bool p_show_error) {
const Variant **argptrs = NULL;
if (p_argcount) {
argptrs = (const Variant **)alloca(sizeof(Variant *) * p_argcount);
for (int i = 0; i < p_argcount; i++) {
argptrs[i] = &p_args[i];
}
}

@bojidar-bg bojidar-bg requested a review from reduz Mar 5, 2019

@akien-mga akien-mga added this to the 3.1 milestone Mar 5, 2019

@akien-mga akien-mga merged commit 45e7306 into godotengine:master Mar 5, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@akien-mga

This comment has been minimized.

Copy link
Member

akien-mga commented Mar 5, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.