Multiplayer API now respects allow_object_decoding #27398
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Note that var decoding is still allowed for
StreamPeer.get_var.I think we need to add an
object_decodingproperty toStreamPeertoo (which could be probably cherry picked to3.0.).2.1is not affected by any of this as object decoding is not implemented.I'm also making a separate branch to fix in
3.0(as the bug is there, but everything related to High Level multiplayer is in SceneTree so cherry picking is not an option).Fixes #27395 .
I'm also wondering, if we should change the defaults for
decode_variantandencode_variantto be safe (no object decoding), and update all their usage where we want object encoding/decoding with the extra parameter to true.