Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the unclickable links inside the doc #28284

Merged
merged 1 commit into from Apr 29, 2019

Conversation

Daw11
Copy link
Contributor

@Daw11 Daw11 commented Apr 21, 2019

Fixes #27384.
Bugsquad edit: Fixes #24920.

This pull fixes the links inside the docs and makes them work correctly.

@akien-mga
Copy link
Member

akien-mga commented Apr 24, 2019

I'd prefer to have separate PRs for both issues, they are unrelated and reviewing feature changes to String will likely take more time than reviewing a bugfix to RichTextLabel. I don't think the new String feature is necessary to fix #27384.

@Daw11
Copy link
Contributor Author

Daw11 commented Apr 27, 2019

@akien-mga I removed all the code that wasn't necessary to fix this bug.

@akien-mga akien-mga merged commit 17ad16e into godotengine:master Apr 29, 2019
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants