Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCons: Default to builtin libpng/freetype on Linux #29998

Merged
merged 1 commit into from Jun 23, 2019

Conversation

Projects
None yet
1 participant
@akien-mga
Copy link
Member

commented Jun 23, 2019

The rationale for keeping those shared by default is that they're typical
dependencies found on any Linux system, and it saves compilation time and
binary size to link their dynamically.

But since official builds default to all-builtin, and Debian/Ubuntu still
don't have libpng16 (which we now require since #29874) readily available
on all their supported releases, it's simpler to bundle all the things.

This does not change the fact that those dependencies can be unbundled
on Linux, it's only the default option changing.

Cf. #29967 and godotengine/godot-docs#2554.

SCons: Default to builtin libpng/freetype on Linux
The rationale for keeping those shared by default is that they're typical
dependencies found on any Linux system, and it saves compilation time and
binary size to link their dynamically.

But since official builds default to all-builtin, and Debian/Ubuntu still
don't have libpng16 (which we now require) readily available on all their
supported releases, it's simpler to bundle all the things.

This does not change the fact that those dependencies *can* be unbundled
on Linux, it's only the default option changing.

@akien-mga akien-mga added this to the 3.2 milestone Jun 23, 2019

akien-mga added a commit to akien-mga/godot-docs that referenced this pull request Jun 23, 2019

Compiling for X11: update distro oneliners
We don't use openssl since 3.1, and we now default to builtin libpng, zlib
and freetype so they don't need to be installed as build dependencies.

Cf. godotengine/godot#29998.

Fixes godotengine#2554.

@akien-mga akien-mga merged commit 4d6ad16 into godotengine:master Jun 23, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@akien-mga akien-mga deleted the akien-mga:x11-builtin-libpng branch Jun 23, 2019

@akien-mga

This comment has been minimized.

Copy link
Member Author

commented Jul 2, 2019

Cherry-picked for 3.1.2.

@akien-mga

This comment has been minimized.

Copy link
Member Author

commented Jul 2, 2019

Cherry-picked for 3.0.7. (And 2.1.6.)

Also defaulted to builtin openssl for those two branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.