Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent GLES2 bool uniforms from having a precision type set. #30331

Merged
merged 1 commit into from Jul 5, 2019

Conversation

@mbrlabs
Copy link
Contributor

mbrlabs commented Jul 4, 2019

When setting the default precision type for uniforms (before compiling the shader) prevent boolean uniforms from having one set. Booleans can't have a precision type and on some Android devices this caused a compilation failure.

Regression from #29014
Fixes #30317

Copy link
Contributor

clayjohn left a comment

Makes sense!

When setting the default precision type for uniforms (before compiling
the shader) prevent boolean uniforms from having one set. Booleans can't
have a precision type and on some Android devices this caused a
compilation failure.

Fixes #30317
@mbrlabs mbrlabs force-pushed the mbrlabs:gles2-bool-fix branch from 9070446 to 10f1e0f Jul 4, 2019
@akien-mga akien-mga added this to the 3.2 milestone Jul 5, 2019
@akien-mga akien-mga merged commit ed96e4a into godotengine:master Jul 5, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@akien-mga

This comment has been minimized.

Copy link
Member

akien-mga commented Jul 5, 2019

Thanks!

@akien-mga

This comment has been minimized.

Copy link
Member

akien-mga commented Jul 17, 2019

Cherry-picked for 3.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.