Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contact shadows appearing when shading casting is off #30764

Merged
merged 1 commit into from Jul 23, 2019

Conversation

@clayjohn
Copy link
Contributor

clayjohn commented Jul 22, 2019

Fixes: #30673

What this does it kicks out objects from the depth-prepass if their shadow casting setting is set to off.

@clayjohn clayjohn requested a review from reduz as a code owner Jul 22, 2019
@akien-mga akien-mga added this to the 3.2 milestone Jul 23, 2019
@akien-mga akien-mga merged commit 0381ff3 into godotengine:master Jul 23, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@akien-mga

This comment has been minimized.

Copy link
Member

akien-mga commented Jul 23, 2019

Thanks!

@akien-mga

This comment has been minimized.

Copy link
Member

akien-mga commented Nov 12, 2019

Cherry-picked for 3.1.2.

@clayjohn clayjohn deleted the clayjohn:contact-shadow branch Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.