Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Script Tool #30852

Open
wants to merge 1 commit into
base: master
from

Conversation

@swarnimarun
Copy link
Contributor

commented Jul 26, 2019

This works but hasn't been stress tested yet so I am gonna leave it as a Draft PR until I get to properly work on it.
Also at the moment, the scene needs to be reloaded for the tool script toggle change to take effect.

Bugsquad edit: Fixes #17338.

@swarnimarun

This comment has been minimized.

Copy link
Contributor Author

commented Jul 26, 2019

Also at the moment, the scene needs to be reloaded for the tool script toggle change to take effect.

This part needs to be fixed for ScriptServers Globally. Haven't looked into fixing it yet.

#25275

@swarnimarun

This comment has been minimized.

Copy link
Contributor Author

commented Jul 26, 2019

Should close #17338

@fire

This comment has been minimized.

Copy link
Member

commented Jul 27, 2019

There are some clang format problems.

@swarnimarun swarnimarun force-pushed the swarnimarun:vs_tools_script branch from 89a1be5 to 95fe76b Aug 7, 2019

@swarnimarun swarnimarun marked this pull request as ready for review Aug 21, 2019

@swarnimarun

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

Opening it for review/testing.

@@ -3532,6 +3537,11 @@ VisualScriptEditor::VisualScriptEditor() {
left_vb->set_v_size_flags(SIZE_EXPAND_FILL);
//left_vb->set_custom_minimum_size(Size2(230, 1) * EDSCALE);

CheckButton *tool_script_check = memnew(CheckButton);
tool_script_check->set_text("Make Tool:");

This comment has been minimized.

Copy link
@akien-mga

akien-mga Sep 3, 2019

Member

Should use TTR() to be translatable.
Also not sure how it looks like, but maybe the colon is redundant with it being a CheckButton? How about "Tool Script" as text?

This comment has been minimized.

Copy link
@swarnimarun

swarnimarun Sep 4, 2019

Author Contributor

makes sense.

@akien-mga

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

Maybe make the commit log a bit more explicit? From simply "Visual Script Tool" it's not clear that this enables VisualScript to be run in-editor as tool scripts (it could also mean "a tool for Visual Script").

@akien-mga
Copy link
Member

left a comment

Style changes requested, otherwise seems good.

@akien-mga

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.