Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle CPUParticles2D visibility when redrawing #30905

Merged
merged 1 commit into from Aug 1, 2019

Conversation

@clayjohn
Copy link
Contributor

clayjohn commented Jul 29, 2019

Addresses: #30672 (not sure if fully fixes)

Code graciously donated by Gamblify

This PR sets the number of visible particles based on the value of redraw. This matches the behaviour of CPUParticles introduced in 24b7f08.

This PR should also regain the performance lost in 24b7f08

@akien-mga akien-mga added this to the 3.2 milestone Jul 29, 2019
@akien-mga akien-mga merged commit 77e8947 into godotengine:master Aug 1, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@akien-mga

This comment has been minimized.

Copy link
Member

akien-mga commented Aug 1, 2019

Thanks!

@akien-mga

This comment has been minimized.

Copy link
Member

akien-mga commented Sep 27, 2019

Cherry-picked for 3.1.2.

@clayjohn clayjohn deleted the clayjohn:set-cpuparticles2d-visible branch Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.