Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement negative for OmniLights and SpotLights in GLES2 #30987

Merged
merged 1 commit into from Aug 5, 2019

Conversation

@clayjohn
Copy link
Contributor

clayjohn commented Jul 31, 2019

Fixes: #30983

Directional light already worked because it is computed in the base pass. OmniLights and Spotlights are computed in accumulation pass, so they need to use subtraction instead of addition.

Reverse color on base pass, use blend_subtract instead of blend_add for other passes.

@clayjohn clayjohn requested a review from reduz as a code owner Jul 31, 2019
@akien-mga akien-mga added this to the 3.2 milestone Jul 31, 2019
@clayjohn clayjohn force-pushed the clayjohn:GLES2-light-negative branch from 8f2bc16 to 96c3004 Jul 31, 2019
@reduz
reduz approved these changes Aug 5, 2019
@akien-mga akien-mga merged commit 7464074 into godotengine:master Aug 5, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@akien-mga

This comment has been minimized.

Copy link
Member

akien-mga commented Aug 5, 2019

Thanks!

@akien-mga

This comment has been minimized.

Copy link
Member

akien-mga commented Nov 8, 2019

Cherry-picked for 3.1.2.

@clayjohn clayjohn deleted the clayjohn:GLES2-light-negative branch Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.