Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocket profiler for HTML5 platform. #33925

Open
wants to merge 9 commits into
base: master
from

Conversation

@Faless
Copy link
Contributor

Faless commented Nov 26, 2019

This PR implements Editor debugger support for the HTML5 platform.

Highlights:

  • Javascript can now be exported with flags (godot export flags).
  • Separate most of the connection logic out of ScriptRemoteDebugger/ScriptEditorDebugger moving that to an appropriate interface.
  • TCP (default) and WebSocket implementations for those interfaces.

Everything should work except for breakpoints/script errors as we cannot receive data while busy waiting in the HTML5 platform.
A potential improvement could be to send the stack frame and error info anyway and pin it somehow to the editor debugger.

A couple of things are hacky. Suggestions are very welcome.

usage3
usage2
usage

@Faless Faless added this to the 4.0 milestone Nov 26, 2019
@Faless Faless requested review from akien-mga and godotengine/network as code owners Nov 26, 2019
@Calinou Calinou added the enhancement label Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.