Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UPNP on windows after #30205. #35953

Merged
merged 1 commit into from Feb 9, 2020

Conversation

@Faless
Copy link
Contributor

Faless commented Feb 6, 2020

The problem could be related to different byte ordering when copying
the interface address over the binding address.

Fixes #35792 (regression after #30205). Will report upstream.

@akien-mga

This comment has been minimized.

Copy link
Member

akien-mga commented Feb 6, 2020

You added the patch but did not apply it to our sources it seems.

The problem could be related to different byte ordering when copying
the interface address over the binding address.
@Faless Faless force-pushed the Faless:upnp/windows_regression branch from b7f36f0 to e853302 Feb 6, 2020
@Faless

This comment has been minimized.

Copy link
Contributor Author

Faless commented Feb 6, 2020

Thanks, 👀

@akien-mga akien-mga modified the milestones: 3.2, 4.0 Feb 6, 2020
@akien-mga akien-mga merged commit ea31f36 into godotengine:master Feb 9, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@akien-mga

This comment has been minimized.

Copy link
Member

akien-mga commented Feb 9, 2020

Thanks!

@akien-mga

This comment has been minimized.

Copy link
Member

akien-mga commented Feb 14, 2020

Cherry-picked for 3.2.1.

@akien-mga

This comment has been minimized.

Copy link
Member

akien-mga commented Feb 14, 2020

Cherry-picked for 3.1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.