Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable NetSocket reuse address on Windows. #36321

Merged
merged 1 commit into from Feb 18, 2020

Conversation

@Faless
Copy link
Contributor

Faless commented Feb 18, 2020

It actually means reuse port -.- ...

See https://docs.microsoft.com/en-us/windows/win32/winsock/so-exclusiveaddruse .

Potentially fixes #35350 . Needs testing.

It actually means reuse port -.- ...
@zaksnet

This comment has been minimized.

Copy link
Contributor

zaksnet commented Feb 18, 2020

It actually means reuse port -.- ...

See https://docs.microsoft.com/en-us/windows/win32/winsock/so-exclusiveaddruse .

Potentially fixes #35350 . Needs testing.

Indeed this fixes #35350 🎉
image

@akien-mga akien-mga merged commit 6e64036 into godotengine:master Feb 18, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@akien-mga

This comment has been minimized.

Copy link
Member

akien-mga commented Feb 18, 2020

Thanks!

@akien-mga

This comment has been minimized.

Copy link
Member

akien-mga commented Feb 20, 2020

Cherry-picked for 3.2.1. (Together with #36349.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.