Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expression: Fix parsing integers as 32-bit #36529

Merged
merged 1 commit into from Feb 25, 2020

Conversation

@akien-mga
Copy link
Member

akien-mga commented Feb 25, 2020

There are still issues as in the inspector text input without a dot will be handled as 64-bit even if it's meant to be a 32-bit integer or float (e.g. with PackedInt32Array added in #36456).

That will need digging further to figure out how to handle this better, but in the meantime it's correct to parse as int64_t and double by default in Expression.

@akien-mga akien-mga added this to the 4.0 milestone Feb 25, 2020
@akien-mga akien-mga merged commit b8f0da7 into godotengine:master Feb 25, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@akien-mga akien-mga deleted the akien-mga:expression-int64 branch Feb 25, 2020
@akien-mga

This comment has been minimized.

Copy link
Member Author

akien-mga commented Mar 4, 2020

Cherry-picked for 3.2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.