Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Replace subpass textures with color in sky shader #37268
This changes the API of the Sky Shader a bit as discussed with reduz on IRC. Instead of giving the user access to the
We can think about re-exposing the textures in the future if there is a need for it. As it stands, neither reduz or I could come up with a good reason to expose the subpass textures directly. Pretty much any use-case would be better served by passing in a ViewportTexture using a uniform.
I will update the blog post accordingly once this is merged.
@akien-mga Thanks, I was able to confirm it. It stems from a problem with all materials right now. When a material is freed, its corresponding shader isn't. This makes sense as shaders can be used by multiple materials. However, I'm not sure how reduz wants to handle it.