[3.x] Fix display of programmatically created value in remote inspector

[timothyqiu]

Programmatically created property value (object) were shown as "Empty" in the remote inspector. (See #28353 and #30033.)

• These objects don't have path, but the empty path check was lost since Fixed error spam in remote debugger #22201.
• Programmatically created value is now shown as an editable "Object ID: XXXX" in remote inspector, the same as in 3.0.6.

The debugger code on master had a huge change, so this PR only targets the 3.2 branch.

p.s. I tried the same approach on master in SceneDebuggerObject::serialize (here) and the value is shown as "Object ID: XXXX" correctly. But clicking it does not make the inspector inspect the object. I'm not familiar with the 4.0 code, so I don't know why it happens and whether that's the expected behavior in 4.0.

[akien-mga]

Thanks!

The debugger code on master had a huge change, so this PR only targets the 3.2 branch.

It would be great to figure it out on master too so that we can have the issue fixed there too for future releases. CC @Faless

[Zireael07]

yippee, this issue masked quite some problems I had, e.g. overly complex collision shapes...

[Faless]

It would be great to figure it out on master too so that we can have the issue fixed there too for future releases. CC @Faless

I think this should be the equivalent change for master:

diff --git a/scene/debugger/scene_debugger.cpp b/scene/debugger/scene_debugger.cpp
index a1d4adcd41..a46f6a0197 100644
--- a/scene/debugger/scene_debugger.cpp
+++ b/scene/debugger/scene_debugger.cpp
@@ -367,7 +367,7 @@ void SceneDebuggerObject::serialize(Array &r_arr, int p_max_size) {
 
                PropertyHint hint = pi.hint;
                String hint_string = pi.hint_string;
-               if (!res.is_null()) {
+               if (!res.is_null() && !res->get_path().is_empty()) {
                        var = res->get_path();
                } else { //only send information that can be sent..
                        int len = 0; //test how big is this to encode

[akien-mga]

Cherry-picked for 3.3.1.