Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize RWLock #45314

Merged
merged 1 commit into from Jan 22, 2021
Merged

Conversation

RandomShaper
Copy link
Member

@RandomShaper RandomShaper commented Jan 19, 2021

Continuing with the effort started with Mutex, and following also what is possible now with Semaphore, RWLock is getting the same kind of changes.

  • Based on C++14's shared_time_mutex
  • No more need to allocate-deallocate or check for null
  • No pointer anymore, just a member variable
  • Platform-specific implementations no longer needed
  • Simpler for NO_THREADS

This code is generously donated by IMVU.

- Based on C++14's `shared_time_mutex`
- No more need to allocate-deallocate or check for null
- No pointer anymore, just a member variable
- Platform-specific implementations no longer needed
- Simpler for `NO_THREADS`
@RandomShaper RandomShaper added this to the 4.0 milestone Jan 19, 2021
@RandomShaper RandomShaper mentioned this pull request Jan 19, 2021
@RandomShaper RandomShaper changed the title Modernize RWLock Modernize RWLock Jan 19, 2021
@RandomShaper RandomShaper marked this pull request as ready for review January 19, 2021 17:40
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@akien-mga akien-mga merged commit d39f638 into godotengine:master Jan 22, 2021
@akien-mga
Copy link
Member

Thanks!

@RandomShaper RandomShaper deleted the modernize_rwlock branch January 22, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants