Support mono devices in WebXR #45444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While it'd be nice to get even more testing, I've gotten a couple reports that this isn't causing any regressions in VR, so I'm taking this out of "Draft" status. BTW, if anyone else would like to test, here's a version of my race car demo that uses this patch: |
akien-mga
approved these changes
Jan 27, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the webxr module is hardcoded to always render in stereo. This PR attempts to detect and support mono devices. It seems to work in some really quick testing (on 3.2, of course!), but I'd like to keep this as a draft for a few days to get some more testing on a couple more devices.
This won't cleanly cherry-pick back to 3.2, so I'll make a separate PR for that.
Fixes #45412