Fix editor re-focus on debugger break on Windows #63286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Jul 21, 2022
RandomShaper
force-pushed
the
fix_debugger_focus
branch
from
dd42e89
to
c1fa682
Compare
RandomShaper
force-pushed
the
fix_debugger_focus
branch
from
c1fa682
to
0330013
Compare
akien-mga
approved these changes
Jul 21, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the once more resurrected bug by which the editor can't claim focus on a debugger break. Repeat with me: on Windows the permission to get focus stealed must be re-granted every time (after new user input).
Quoting https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-allowsetforegroundwindow:
Additionally, the various cases of
(p_)allow_focus_steal_pidare renamed to(p_)editor_pidand the relevant command-line option is hyphenated instead of "underscorated".