Add Text Server related options to the build profiles editor. #63871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bruvzg
commented
Aug 3, 2022
bruvzg
commented
- Adds SCons options to disable Brotli and Graphite.
- Adds option categories to the build profiles editor.
- Adds options default state to the build profiles editor.
- Adds Text Server related options to the build profiles editor.
- Fix misplaced OpenGL/Vulkan SCons options (were shifted due to missing "rendering device" option).
bruvzg
force-pushed
the
ts_build_options
branch
from
b89b95d
to
2ba1f8c
Compare
akien-mga
reviewed
Aug 3, 2022
modules/freetype/config.py
Outdated
Comment on lines
6
to
12
| from SCons.Script import BoolVariable, PathVariable, Variables, Help | ||
|
|
||
| opts = Variables() | ||
| opts.Add(BoolVariable("brotli", "Enable Brotli decompressor for WOFF2 fonts support", True)) | ||
|
|
||
| opts.Update(env) | ||
| Help(opts.GenerateHelpText(env)) |
There was a problem hiding this comment.
I think updating the opts and help might mess with this hack repeated multiple times in the SConstruct:
Line 307 in 2c0c76c
We should probably solve it properly as it's a hassle.
As a side note, PathVariable doesn't seem used?
There was a problem hiding this comment.
"Mono" module seems to be doing the same, without resetting env_base["platform"].
Maybe modules should have separate function to return options, like platforms.
There was a problem hiding this comment.
I think updating the opts and help might mess with this hack repeated multiple times
Does not seem to be any difference, but I have replaced it with the get_opts() method, similar to the one used in platforms.
bruvzg
force-pushed
the
ts_build_options
branch
from
2ba1f8c
to
3969fc7
Compare
bruvzg
force-pushed
the
ts_build_options
branch
from
3969fc7
to
e011b70
Compare
Adds SCons options to disable Brotli and Graphite. Adds option categories to the build profiles editor. Adds options default state to the build profiles editor. Adds Text Server related options to the build profiles editor. Fix misplaced OpenGL/Vulkan SCons options.
bruvzg
force-pushed
the
ts_build_options
branch
from
e011b70
to
066ca97
Compare
akien-mga
approved these changes
Aug 5, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.