Add call_deferred() method to Callable #67730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
force-pushed
the
late_to_the_call
branch
2 times, most recently
from
2e1c0c5
to
189c9dc
Compare
KoBeWi
force-pushed
the
late_to_the_call
branch
from
189c9dc
to
932f0da
Compare
akien-mga
reviewed
Nov 4, 2022
core/variant/callable.h
Outdated
| @@ -73,6 +73,16 @@ class Callable { | |||
| void call_deferredp(const Variant **p_arguments, int p_argcount) const; | |||
| Variant callv(const Array &p_arguments) const; | |||
|
|
|||
| template <typename... VarArgs> | |||
| void call_deferred(VarArgs... p_args) const { | |||
| Variant args[sizeof...(p_args) + 1] = { p_args..., Variant() }; // +1 makes sure zero sized arrays are also supported. | |||
There was a problem hiding this comment.
./core/variant/callable.h:78:54: error: invalid use of incomplete type 'Variant'
Variant args[sizeof...(p_args) + 1] = { p_args..., Variant() }; // +1 makes sure zero sized arrays are also supported.
^~~~~~~~~
./core/variant/array.h:38:7: note: forward declaration of 'Variant'
class Variant;
^
Should likely be in the .cpp as we probably don't want to include Variant here to avoid circular deps.
There was a problem hiding this comment.
Template functions can't be defined in cpp. I found a promising workaround though.
akien-mga
approved these changes
Nov 4, 2022
KoBeWi
force-pushed
the
late_to_the_call
branch
from
932f0da
to
1778301
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatever reason the C++ Callable never got
call_deferred()method and to defer a call you had tocall_deferredp(nullptr, 0);.