C#: Optimize Variant conversion callbacks #68310
Conversation
|
I made an example with some stubs in SharpLab to help visualize these optimizations (change the results view to For Godot projects, I don't know how to visualize JIT generated code (I trusted the SharpLab output in this case). If you enable NativeAOT, you can use objdump with the compiled library. |
neikeq
force-pushed
the
csharp-opt-variant-generic-conv
branch
from
fbabe2d
to
415b068
Compare
These callbacks are used for marshaling by callables and generic Godot collections. C# generics don't support specialization the way C++ templates do. I knew NativeAOT could optimize away many type checks when the types are known at compile time, but I didn't trust the JIT would do as good a job, so I initially went with cached function pointers. Well, it turns out the JIT is also very good at optimizing in this scenario, so I'm changing the methods to do the conversion directly, rather than returning a function pointer for the conversion. The methods were moved to `VariantUtils`, and were renamed from `GetFromVariantCallback/GetToVariantCallback` to `ConvertTo/CreateFrom`. The new implementation looks like it goes through many `if` checks at runtime to find the right branch for the type, but in practice it works pretty much like template specialization. The JIT only generates code for the relevant branch. Together with inlining, the result is very close or the same as doing the conversion manually: ```cs godot_variant variant; int foo = variant.Int; int bar = VariantUtils.ConvertTo<int>(variant); ``` If the type is a generic Godot collection, the conversion still goes through a function pointer call. The new code happens to be much shorter as well, with the file going from 1057 lines to 407. Side note: `Variant.cs` was mistakenly created in the wrong folder, so I moved it to the `Core` folder.
neikeq
force-pushed
the
csharp-opt-variant-generic-conv
branch
from
415b068
to
3f645f9
Compare
modules/mono/glue/GodotSharp/GodotSharp/Core/NativeInterop/VariantUtils.generic.cs
Show resolved
Hide resolved
| @@ -54,7 +54,7 @@ static void Trampoline(object delegateObj, NativeVariantPtrArgs args, out godot_ | |||
| ThrowIfArgCountMismatch(args, 1); | |||
|
|
|||
| ((Action<T0>)delegateObj)( | |||
| VariantConversionCallbacks.GetToManagedCallback<T0>()(args[0]) | |||
| VariantUtils.ConvertTo<T0>(args[0]) | |||
There was a problem hiding this comment.
Interesting, does the analyzer not complain that T0 is not annotated with [MustBeVariant]?
There was a problem hiding this comment.
Oh, I see, the analyzer is in Godot.SourceGenerators but in GodotSharp we are only using Godot.SourceGenerators.Internal. So the analyzer is not run for GodotSharp but it will be run in user projects.
That's a shame because we missed the [MustBeVariant] attribute here and we need it if we want to prevent this:
Callable.From((NonMarshableType a) => ...);There was a problem hiding this comment.
We could extract the analyzer to its own project/assembly to re-use it.
|
Thanks! |
These callbacks are used for marshaling by callables and generic Godot collections.
C# generics don't support specialization the way C++ templates do. I knew NativeAOT could optimize away many type checks when the types are known at compile time, but I didn't trust the JIT would do as good a job, so I initially went with cached function pointers.
Well, it turns out the JIT is also very good at optimizing in this scenario, so I'm changing the methods to do the conversion directly, rather than returning a function pointer for the conversion.
The methods were moved to
VariantUtils, and were renamed fromGetFromVariantCallback/GetToVariantCallbacktoConvertTo/CreateFrom.The new implementation looks like it goes through many
ifchecks at runtime to find the right branch for the type, but in practice it works pretty much like template specialization. The JIT only generates code for the relevant branch. Together with inlining, the result is very close or the same as doing the conversion manually:If the type is a generic Godot collection, the conversion still goes through a function pointer call.
The new code happens to be much shorter as well, with the file going from 1057 lines to 407.
Side note:
Variant.cswas mistakenly created in the wrong folder, so I moved it to theCorefolder.