Fix RichTextLabel crash with out of bound exception #68325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
None of your builds seem to have to pass. Please do a rebase and try building it locally again to see if this is even valid. |
pfertyk
force-pushed
the
issue-68242-rich-text-label-crash
branch
from
1ff2d39
to
00c4ad7
Compare
|
Rebase done, but I can see the warnings. I'll check if I can do something about them next week. |
is the error you're getting. |
bruvzg
reviewed
Feb 28, 2023
pfertyk
force-pushed
the
issue-68242-rich-text-label-crash
branch
from
00c4ad7
to
7117c87
Compare
pfertyk
force-pushed
the
issue-68242-rich-text-label-crash
branch
from
7117c87
to
44592c8
Compare
|
While this would fix the crash, I'm not sure why we arrive in this state in the first place. It feels like there is some underlying problem (and of course the reported issue is completely artificial, which might be the reason for this weird state). But if @bruvzg approves, I think we can merge it as is. |
bruvzg
approved these changes
Mar 8, 2023
|
Thanks! |
|
Cherry-picked for 4.0.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #68242.
I am not completely sure how the
_find_listmethod works 馃槄 This check will stop the error from happening, but perhaps the iteration itself is not valid now. We are iterating overlistandprev_itemand then using the index to accessframe->lines, and I'm not sure if that process is correct. If this fix should be implemented differently, please let me know 馃槃