Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add open scene button in Inspector for PackedScene resource #69938

Merged
merged 1 commit into from Dec 13, 2022

Conversation

timothyqiu
Copy link
Member

Closes godotengine/godot-proposals#3338

Adds an "Open Scene" button when editing a PackedScene resource:

ksnip_20221212-111523

@fire
Copy link
Member

fire commented Dec 12, 2022

This feature is great from a usability point of view if you're storing packed scenes in an export variable.

Don't have much time to review the code though.

Edited:

It's a bit short so may be easy to review.


void PackedSceneEditor::_notification(int p_what) {
switch (p_what) {
case NOTIFICATION_ENTER_TREE:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we needed a [[fallthrough]] here? Did something change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[[fallthrough]] is not required if the case does nothing on its own. See #58151.

Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a github.com review, There's some minor comments, but nothing big.

I did not execute the cicd build for review.

@akien-mga akien-mga merged commit ad7b31f into godotengine:master Dec 13, 2022
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the open-packed-scene branch December 13, 2022 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to open a scene that is stored in an export(PackedScene) field from the inspector
3 participants