Add NavigationLink helper functions for global positions #73229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarkKilauea
suggested changes
Feb 14, 2023
Adds helper functions to set the links start and end position with global positions or get them as global positions. Adds global start and end position for the navigation link to the 'link_reached' signal of NavigationAgent. That signal gets emitted when a navigation link waypoint is reached. Requires that 'owner' meta data is enabled on the NavigationAgent.
smix8
force-pushed
the
navlink_global_positions_4.x
branch
from
0ff47ea
to
d87f124
Compare
akien-mga
approved these changes
Feb 15, 2023
DarkKilauea
approved these changes
Feb 16, 2023
|
LGTM |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
NavigationLinkhelper functions to set the links start and end position with global positions or get them as global positions.Adds global start and end position for the navigation link to the
link_reachedsignal ofNavigationAgent. That signal gets emitted when a navigation link waypoint is reached. Requires thatownermeta data is enabled on the NavigationAgent.Also fixes the problems mentioned in the proposal discussion here godotengine/godot-proposals#6167
While helping out GDQuest with a navigation demo I noticed myself that a lot of script boilerplate is needed to make good use of the current NavigationLink positions or the NavigationAgent signal so I added helpers and added to the signal data.