Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci/web] update mymindstorm/setup-emsdk to v12 #75339

Merged
merged 1 commit into from Mar 26, 2023

Conversation

umarcor
Copy link
Contributor

@umarcor umarcor commented Mar 26, 2023

Fix the warning that is shown in the web workflow:

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: mymindstorm/setup-emsdk@v11. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

Was fixed in mymindstorm/setup-emsdk@ed0d39a. See mymindstorm/setup-emsdk#28.

@umarcor umarcor requested a review from a team as a code owner March 26, 2023 01:15
@akien-mga akien-mga added enhancement platform:web topic:buildsystem cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release cherrypick:4.0 labels Mar 26, 2023
@akien-mga akien-mga added this to the 4.1 milestone Mar 26, 2023
@akien-mga akien-mga merged commit 6ef2f35 into godotengine:master Mar 26, 2023
13 checks passed
@akien-mga
Copy link
Member

Thanks!

@umarcor umarcor deleted the umarcor/ci/setup-emsdk branch March 26, 2023 02:11
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.2.

@akien-mga
Copy link
Member

Cherry-picked for 3.6.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label May 11, 2023
@akien-mga
Copy link
Member

Cherry-picked for 3.5.3.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants