Consider visual layers for DirectionalLight

[SlashScreen]

Here, I have applied the patch provided by @majikayogames, in an updated line number to reflect the updated rendering engine. This should close #74545.
A concern was brought up about the directional lights not being considered for culling earlier in the function, but I don't believe there is any way to be confident you can cull a directional light without first rendering the shadowmap. If I am wrong, let me know.
I have been running a version of Godot that contains this patch, and I have seen no issues thus far.

[akien-mga]

Could you amend the commit message to be more explicit about what said patch does? E.g. like @AThousandShips used to edit the PR title. See https://github.com/godotengine/godot/blob/master/CONTRIBUTING.md#format-your-commit-messages-with-readability-in-mind

[SlashScreen]

Could you amend the commit message to be more explicit about what said patch does? E.g. like @AThousandShips used to edit the PR title. See https://github.com/godotengine/godot/blob/master/CONTRIBUTING.md#format-your-commit-messages-with-readability-in-mind

Done. Although, I seem to have accidentally included the last PR in my PR. I'm not entirely sure how to fix that.

[AThousandShips]

You need to drop it with git rebase -i master, and just replace keep pick with drop for the first one

[SlashScreen]

You need to drop it with git rebase -i master, and just replace keep with drop for the first one

Only my commit shows up in git rebase -i master, and did you mean pick, not keep?

[Calinou]

Tested locally, it works as expected in all rendering methods.

[AThousandShips]

When you finish the rebase, is the broken commit still there? It should probably have been replaced with the proper one, check the log with git log

[clayjohn]

The change to renderer_scene_cull looks great!

You will need to remove your accidental commit before this is ready to merge though

[SlashScreen]

The change to renderer_scene_cull looks great!

You will need to remove your accidental commit before this is ready to merge though

Right-o. I think I removed it. It says "commits : 1" now.

[clayjohn]

The change to renderer_scene_cull looks great!
You will need to remove your accidental commit before this is ready to merge though

Right-o. I think I removed it. It says "commits : 1" now.

It looks great now. Thank you!

[SlashScreen]

Is this still slated for a maintenance release?

[clayjohn]

Is this still slated for a maintenance release?

Yes, this should be fine to merge for 4.3.1

[SlashScreen]

Alright, noted. I’m not asking to be pushy, but why not in 4.3? I don’t yet know the thought process for what gets included for a main release vs what is moved to a maintenance release. Is it simply that it’s an unproven fix?

…

Message ID: ***@***.***>

[clayjohn]

Alright, noted. I’m not asking to be pushy, but why not in 4.3? I don’t yet know the thought process for what gets included for a main release vs what is moved to a maintenance release. Is it simply that it’s an unproven fix?
…
Message ID: @.***>

We are just too late in the 4.3 process. In the Release Candidate phase we only merge urgent fixes and we have already done 3 RCs. We have to draw the line somewhere or else we will never release 4.3

[SlashScreen]

Ah, that makes sense.

…

Message ID: ***@***.***>

[SlashScreen]

If majikayo isn't already a contributor, is there a way to include them as a contributor? they did most of the work here, hunting down the issue and providing a fix. All I did was put it in the right spot.

[AThousandShips]

You can add them as a co-author, you need to find their GitHub handle from some commit and add:

Co-authored-by: [username] <[email]>

The empty line is necessary and the details can be gotten from a commit of theirs with git log

[SlashScreen]

You can add them as a co-author, you need to find their GitHub handle from some commit and add:

Co-authored-by: [username] <[email]>

The empty line is necessary and the details can be gotten from a commit of theirs with git log

Add this to what? The commit message?

[AThousandShips]

Yes exactly

[SlashScreen]

Got it. Thanks.

[SlashScreen]

Alright, is it showtime?

[clayjohn]

Alright, is it showtime?

It's showtime 😎

[akien-mga]

Thanks!

[akien-mga]

Cherry-picked for 4.3.1.