From 92845a04f6c97b741837d600b11d81afdfa5a66d Mon Sep 17 00:00:00 2001 From: keroro Date: Mon, 29 Aug 2022 17:02:42 +0800 Subject: [PATCH] fix: declare StorageKey as HexNumber type Why: https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1474.md#eth_getstorageat --- packages/api-server/src/methods/modules/eth.ts | 2 +- packages/api-server/src/methods/validator.ts | 15 --------------- 2 files changed, 1 insertion(+), 16 deletions(-) diff --git a/packages/api-server/src/methods/modules/eth.ts b/packages/api-server/src/methods/modules/eth.ts index 2c12e6ad..e04acaca 100644 --- a/packages/api-server/src/methods/modules/eth.ts +++ b/packages/api-server/src/methods/modules/eth.ts @@ -131,7 +131,7 @@ export class Eth { ]); this.getStorageAt = middleware(this.getStorageAt.bind(this), 3, [ validators.address, - validators.storageKey, + validators.hexNumber, validators.blockParameter, ]); this.getTransactionCount = middleware( diff --git a/packages/api-server/src/methods/validator.ts b/packages/api-server/src/methods/validator.ts index 0b8c9eea..dab15194 100644 --- a/packages/api-server/src/methods/validator.ts +++ b/packages/api-server/src/methods/validator.ts @@ -76,10 +76,6 @@ export const validators = { return verifyHexNumber(params[index], index); }, - storageKey(params: any[], index: number) { - return verifyStorageKey(params[index], index); - }, - /** * Hex number | "latest" | "earliest" | "pending" * @param params @@ -427,17 +423,6 @@ export function verifyEstimateGasCallObject( return undefined; } -export function verifyStorageKey( - key: string, - index: number -): InvalidParamsError | undefined { - const err = verifyHexString(key, index); - if (err) { - return err.padContext("storageKey"); - } - return undefined; -} - export function verifyFilterTopicString( topic: any, index: number