Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

post-spawnfest #1

Closed
wants to merge 8 commits into
from

Conversation

Projects
None yet
4 participants

Hello, we've used yamler for our Spawnfest project this year; as a result, we've went over the source code and "cleaned it up" a bit, do you think that would be useful to merge into upstream?

P. S.: Probably, removing libyaml was kind of harsh, but what's the point of keeping it in the repo, when the library is available in all the major distros.

superbobry added some commits Jul 7, 2012

@superbobry superbobry Enabled draconian GCC flags -- safety matters 4f978e9
@superbobry superbobry Major 'c_src' cleanup
  - Removed 'libyaml', no point of having it locally, since it's a separate
    project
  - (hopefully) improved readability of 'libyaml' NIF
d1b05a2
@superbobry superbobry More minor 'c_src' changes d190267
@superbobry superbobry Cleaned up type specs in 'yaml_libyaml' a5f73be
@superbobry superbobry Cleaned up error formatting a bit
  Having an 'fprintf' call in a NIF! doh ...
925c72d
@superbobry superbobry Added a note about 'libyaml' sources
  (which are no longer hosted in the repository)
b687727
Owner

goertzenator commented Jul 25, 2012

Glad to hear you are having success with yamler!

A major distro for which libyaml is not conveniently available is Windows, and I have plans to use use yamler on Windows in the not to distant future. So I really would like to keep the libyaml source in the repo. If you really want to use the system libyaml, perhaps that could be a build option?

I think libyaml could genuinely go away if a native Erlang parser was written.

Can the exit() call be changed back to nif_error()? This will make dialyzer happy; I assume dialyzer will fuss over the exit() call.

Owner

superbobry replied Jul 25, 2012

Indeed it can, sorry, I must have copy-pasted the line from one of my NIF-based projects.

Owner

goertzenator commented Jul 25, 2012

FYI, I am going to merge at least some of this. I've never handled a pull request before so I have some learning to do...

Great! let me know if you wan't me to fix something (or in fact anything), before merging ;)

@superbobry superbobry closed this Jul 16, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment