Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃 Source file name typo in limiter package? #1747

Closed
NorbertHauriel opened this issue Feb 3, 2022 · 2 comments
Closed

馃 Source file name typo in limiter package? #1747

NorbertHauriel opened this issue Feb 3, 2022 · 2 comments

Comments

@NorbertHauriel
Copy link
Contributor

NorbertHauriel commented Feb 3, 2022

The following source files are named with a prefix 'limited' in package limiter:

  • limited_fixed.go
  • limited_sliding.go

I would expect 'limiter', just like the package's name, and the already existing limiter.go and limiter_test.go.
Is this a typo? Seems like it, but I'm not sure.

@welcome
Copy link

welcome bot commented Feb 3, 2022

Thanks for opening your first issue here! 馃帀 Be sure to follow the issue template! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

@hi019
Copy link
Member

hi019 commented Feb 3, 2022

Yep, it's a typo

NorbertHauriel added a commit to NorbertHauriel/fiber that referenced this issue Feb 3, 2022
NorbertHauriel added a commit to NorbertHauriel/fiber that referenced this issue Feb 3, 2022
NorbertHauriel added a commit to NorbertHauriel/fiber that referenced this issue Feb 3, 2022
hi019 pushed a commit that referenced this issue Feb 3, 2022
@hi019 hi019 closed this as completed Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants