Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: print all routes message when server starts #1677

Merged
merged 6 commits into from Dec 30, 2021

Conversation

vecpeng
Copy link
Contributor

@vecpeng vecpeng commented Dec 29, 2021

Closes #1675
It will print something like this:
image

@efectn
Copy link
Member

efectn commented Dec 29, 2021

I think you can add "-"s after the table head. It would be great

@ReneWerner87 ReneWerner87 self-requested a review Dec 29, 2021
Copy link
Member

@ReneWerner87 ReneWerner87 left a comment

Please add the isChild check for our prefork mode
https://github.com/gofiber/fiber/blob/master/app.go#L1001

@ReneWerner87
Copy link
Member

ReneWerner87 commented Dec 29, 2021

Please add a part for the doc repository https://github.com/gofiber/docs/blob/master/api/fiber.md#config

@vecpeng
Copy link
Contributor Author

vecpeng commented Dec 29, 2021

Ok,I will fix them tomorrow.

@vecpeng
Copy link
Contributor Author

vecpeng commented Dec 30, 2021

Thanks for your review. I finish them @ReneWerner87

@vecpeng vecpeng requested a review from ReneWerner87 Dec 30, 2021
@ReneWerner87
Copy link
Member

ReneWerner87 commented Dec 30, 2021

#1677 (comment)

@@ -737,6 +751,10 @@ func (app *App) Listen(addr string) error {
if !app.config.DisableStartupMessage {
app.startupMessage(ln.Addr().String(), false, "")
}
// Print routes
if app.config.EnablePrintRoutes {
app.printRoutesMessage()
Copy link
Member

@ReneWerner87 ReneWerner87 Dec 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget the Listener and ListenTLS method.

@ReneWerner87 ReneWerner87 merged commit f98a9ba into gofiber:master Dec 30, 2021
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants