Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change json tag for EnablePrintRoutes #1702

Merged
merged 1 commit into from Jan 10, 2022

Conversation

vecpeng
Copy link
Contributor

@vecpeng vecpeng commented Jan 10, 2022

json:"print_routes" => json:"enable_print_routes"

@ReneWerner87
Copy link
Member

ReneWerner87 commented Jan 10, 2022

this is a breaking change, please always consider at the beginning
(initial implementation #1677)

this time it will still work, because not many use this feature and also don't use json representation, but next time please fix it right away

@ReneWerner87 ReneWerner87 changed the title 🐛fix: json tag change json tag for EnablePrintRoutes Jan 10, 2022
@ReneWerner87 ReneWerner87 merged commit 2e697a6 into gofiber:master Jan 10, 2022
14 checks passed
@vecpeng
Copy link
Contributor Author

vecpeng commented Jan 10, 2022

I'm so sorry for for carelessness. I won't make same mistake next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants