Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add direct download option when serving static files #1729

Merged
merged 2 commits into from Feb 3, 2022

Conversation

Lian1230
Copy link
Contributor

@Lian1230 Lian1230 commented Jan 22, 2022

Explain the details for making this change. What existing problem does the pull request solve?

For HTML element's download attribute, serverside header response must include "Content-Disposition: attachment" for cross origin request.

@welcome
Copy link

welcome bot commented Jan 22, 2022

Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

Copy link
Member

@ReneWerner87 ReneWerner87 left a comment

@Lian1230
Please provide some unittests cases for this feature.

@ReneWerner87
Copy link
Member

ReneWerner87 commented Jan 24, 2022

And don't forget the document repository https://github.com/gofiber/docs

@ReneWerner87
Copy link
Member

ReneWerner87 commented Jan 27, 2022

@Lian1230

hi019
hi019 approved these changes Feb 3, 2022
@ReneWerner87 ReneWerner87 merged commit af10fab into gofiber:master Feb 3, 2022
14 checks passed
@welcome
Copy link

welcome bot commented Feb 3, 2022

Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

NorbertHauriel pushed a commit to NorbertHauriel/fiber that referenced this issue Feb 3, 2022
* enable download for app.Static


wording

* Add unit test.

Co-authored-by: Muhammed Efe Çetin <efectn@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants