Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added HEAD method to caching #1730

Merged
merged 4 commits into from Jan 24, 2022

Conversation

jessequinn
Copy link
Contributor

@jessequinn jessequinn commented Jan 23, 2022

When using the curl -I statement, the HEAD method, is invoked. However, only the GET method is being cached. To overcome this limitation an additional clause was added to the cache.go to allow the HEAD method to also cache.

@welcome
Copy link

welcome bot commented Jan 23, 2022

Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

@ReneWerner87
Copy link
Member

ReneWerner87 commented Jan 23, 2022

Unfortunately, the adaptation has addressed a wider memory allocation, making the process slower

I am in exchange with the author of the pr and we are trying to reduce this allocation

- add a improvement task for later
correct comment
@ReneWerner87
Copy link
Member

ReneWerner87 commented Jan 24, 2022

have added a comment, for optimization experts

@ReneWerner87 ReneWerner87 merged commit d411ec1 into gofiber:master Jan 24, 2022
14 checks passed
@welcome
Copy link

welcome bot commented Jan 24, 2022

Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants