Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc(limiter): clarify variable name 'expire' #1742

Merged
merged 1 commit into from Feb 3, 2022

Conversation

NorbertHauriel
Copy link
Contributor

@NorbertHauriel NorbertHauriel commented Feb 2, 2022

  • The variable 'expire' doesn't imply why it is different from 'expiration', so I made its name more specific.
  • Comments mentioning it were changed accordingly.

@welcome
Copy link

welcome bot commented Feb 2, 2022

Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

This clarifies the intent of variable 'expire' by renaming to
the more understandable 'resetInSec'. All mentions are renamed as well.
@NorbertHauriel NorbertHauriel marked this pull request as draft Feb 2, 2022
@NorbertHauriel NorbertHauriel marked this pull request as ready for review Feb 2, 2022
@NorbertHauriel NorbertHauriel changed the title ♻️ Refactor(limiter): remove and rename expiration variable Doc(limiter): clarify variable name 'expire' Feb 2, 2022
@NorbertHauriel NorbertHauriel requested a review from ReneWerner87 Feb 2, 2022
@ReneWerner87 ReneWerner87 merged commit d85ae2b into gofiber:master Feb 3, 2022
14 checks passed
@welcome
Copy link

welcome bot commented Feb 3, 2022

Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants