Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: mounted app views #1749

Merged
merged 4 commits into from Feb 6, 2022

Conversation

efectn
Copy link
Member

@efectn efectn commented Feb 4, 2022

Fixes #1276

Copy link
Member

@ReneWerner87 ReneWerner87 left a comment

instead of adding a list for the properties we want to take from the mounted apps, we should solve this differently

had some communication with the author of the pull request and we are working on a better variant

something like this
image
image
image
image

Co-authored-by: RW <rene@gofiber.io>
@efectn efectn requested a review from ReneWerner87 Feb 5, 2022
@ReneWerner87 ReneWerner87 merged commit c450072 into gofiber:master Feb 6, 2022
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants