Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default gc interval of internal/memory #1756

Merged
merged 1 commit into from Feb 7, 2022

Conversation

efectn
Copy link
Member

@efectn efectn commented Feb 6, 2022

10ms interval time causes big performance degradation. So i made it 1 second. Potentially closes #1371.

Before:

Running 10s test @ http://127.0.0.1:5000
  12 threads and 100 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     2.99s     1.91s    6.69s    52.54%
    Req/Sec       -nan      -nan   0.00      0.00%
  396049 requests in 10.00s, 94.05MB read
Requests/sec:  39612.49
Transfer/sec:      9.41MB

After:

Running 10s test @ http://127.0.0.1:5000
  12 threads and 100 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     2.12s     1.24s    4.61s    55.31%
    Req/Sec       -nan      -nan   0.00      0.00%
  602860 requests in 10.00s, 143.16MB read
Requests/sec:  60310.52
Transfer/sec:     14.32MB

@ReneWerner87
Copy link
Member

ReneWerner87 commented Feb 6, 2022

Will do the deep check tomorrow.

@ReneWerner87 ReneWerner87 merged commit 8bd1509 into gofiber:master Feb 7, 2022
14 checks passed
@ReneWerner87
Copy link
Member

ReneWerner87 commented Feb 7, 2022

@efectn can you check the memory storage in the storages repository
https://github.com/gofiber/storage/blob/main/memory/memory.go#L99
looks that the adapter is outdated ... maybe we can refresh it with the last changes

@efectn
Copy link
Member Author

efectn commented Feb 7, 2022

@efectn can you check the memory storage in the storages repository https://github.com/gofiber/storage/blob/main/memory/memory.go#L99 looks that the adapter is outdated ... maybe we can refresh it with the last changes

I'll check it weekend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants