Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃┕ fix: backwards incompatible change to fiber.Error #1768

Merged
merged 2 commits into from Feb 14, 2022

Conversation

balcieren
Copy link
Member

@balcieren balcieren commented Feb 11, 2022

fix #1767

backward compatible

@liaohongxing
Copy link
Contributor

liaohongxing commented Feb 12, 2022

This broken change should wait for V3, AnyMessage is not elegant

@hi019
Copy link
Member

hi019 commented Feb 12, 2022

I agree with the previous reply, I think we should remove the AnyMessage changes and then merge this PR. Users can always return their own custom error in a handler and then convert it to JSON in the ErrorHandler.

After this is merged, we can do a quick release to restore compatibility.

@hi019 hi019 requested a review from ReneWerner87 Feb 12, 2022
@ReneWerner87
Copy link
Member

ReneWerner87 commented Feb 12, 2022

Am of the same opinion, let's correct the error and work backward compatible

@balcieren
Copy link
Member Author

balcieren commented Feb 12, 2022

Am of the same opinion, let's correct the error and work backward compatible

Message should be interface for v3. May I fix over this pr ?

@tomaswarynyca
Copy link
Contributor

tomaswarynyca commented Feb 13, 2022

Ready? 馃殌

hi019
hi019 approved these changes Feb 14, 2022
@ReneWerner87 ReneWerner87 merged commit 74a20b4 into gofiber:master Feb 14, 2022
14 checks passed
ReneWerner87 added a commit to gofiber/docs that referenced this pull request Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants